-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[llvm] Avoid creating new LLVM contexts when updating struct module #5397
Conversation
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
/rebase |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
05d48e5
to
256ba9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Detailed comments regarding the renaming rule would be nicer~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
} | ||
if (required->isPointerTy()) { | ||
required = required->getPointerElementType(); | ||
provided = provided->getPointerElementType(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: is it cleaner to just return is_same_type(required->getPointerElementType(), provided->getPointerElementType())
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah... I'll send another pr to fix this.
Related issue = #5252
Types in modules imported from file/other contexts may be renamed to "original_type.xxx" when the type is imported multiple times. So, we need to insert a pointer cast when the parameter type of a function is renamed.